mirror
/
libx52
mirror of https://github.com/nirenjan/libx52.git
1
0
Fork 0
Code Releases Wiki Activity

fix: Use logical operators with boolean arguments 

SonarQube flagged the use of bitwise operators with boolean variables.
This is changed to use the correct logical operators instead of their
bitwise equivalents.
mouse-isometric-mode
nirenjan 2026-03-30 11:47:12 -07:00
parent 283b476c5e
commit 6a36fc7764
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
daemon/x52d_mouse_handler.c
View File

@ -63,8 +63,8 @@ static int report_wheel(void)
* hardware axis is very noisy and the firmware sends a sequence of reports
* with button down, even though this is technically a momentary button.
*/
scroll_up = (scroll_up ^ old_scroll_up) & scroll_up;
scroll_dn = (scroll_dn ^ old_scroll_dn) & scroll_dn;
scroll_up &&= !old_scroll_up;
scroll_dn &&= !old_scroll_dn;
if (scroll_up) {
// Scroll up event
@ -215,9 +215,9 @@ void x52d_mouse_report_event(libx52io_report *report)
}
state_changed = false;
state_changed |= (0 == report_button_change(VKM_MOUSE_BTN_LEFT, LIBX52IO_BTN_MOUSE_PRIMARY));
state_changed |= (0 == report_button_change(VKM_MOUSE_BTN_RIGHT, LIBX52IO_BTN_MOUSE_SECONDARY));
state_changed |= (0 == report_wheel());
state_changed ||= (0 == report_button_change(VKM_MOUSE_BTN_LEFT, LIBX52IO_BTN_MOUSE_PRIMARY));
state_changed ||= (0 == report_button_change(VKM_MOUSE_BTN_RIGHT, LIBX52IO_BTN_MOUSE_SECONDARY));
state_changed ||= (0 == report_wheel());
if (state_changed) {
report_sync();