From b0150c46b8a9a8b17f2fb222e003c1e1161ad0b5 Mon Sep 17 00:00:00 2001 From: nirenjan Date: Thu, 13 Aug 2020 15:17:14 -0700 Subject: [PATCH] Remove unnecessary probe and remove functions There's no need to create custom probe and remove functions - the default behavior is sufficient. --- kernel_module/hid-saitek-x52.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/kernel_module/hid-saitek-x52.c b/kernel_module/hid-saitek-x52.c index b138b6e..15b1654 100644 --- a/kernel_module/hid-saitek-x52.c +++ b/kernel_module/hid-saitek-x52.c @@ -187,31 +187,6 @@ static int x52_input_mapping(struct hid_device *dev, return -1; } -static int x52_probe(struct hid_device *dev, const struct hid_device_id *id) -{ - int ret; - - hid_set_drvdata(dev, NULL); - ret = hid_parse(dev); - if (ret != 0) { - hid_err(dev, "parse failed\n"); - return ret; - } - - ret = hid_hw_start(dev, HID_CONNECT_DEFAULT); - if (ret != 0) { - hid_err(dev, "hw start failed\n"); - return ret; - } - - return 0; -} - -static void x52_remove(struct hid_device *dev) -{ - hid_hw_stop(dev); -} - static const struct hid_device_id x52_devices[] = { { HID_USB_DEVICE(VENDOR_SAITEK, DEV_X52_1) }, { HID_USB_DEVICE(VENDOR_SAITEK, DEV_X52_2) }, @@ -224,8 +199,6 @@ MODULE_DEVICE_TABLE(hid, x52_devices); static struct hid_driver x52_driver = { .name = "saitek-x52", .id_table = x52_devices, - .probe = x52_probe, - .remove = x52_remove, .input_mapping = x52_input_mapping, .input_configured = x52_input_configured, .raw_event = x52_raw_event,