mirror
/
pinelog
mirror of https://github.com/nirenjan/pinelog.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use an in-memory pipe for tests 

Prior to this change, the test harness was creating a FIFO on disk using
`mkfifo`. This is really unnecessary, and we can use `pipe` instead to
create a pair of file descriptors corresponding to a FIFO in memory,
without having to go to disk at all.

This change creates the FIFO and sets it to non-blocking to emulate the
existing behavior.
master
nirenjan 2021-10-25 12:47:10 -07:00
parent 0256807417
commit 349b2d6e86
1 changed files with 35 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
test_pinelog.c
View File

@ -13,11 +13,12 @@
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <limits.h> #include <limits.h>
#include <errno.h>
#include <time.h> #include <time.h>
#include <sys/types.h> #include <sys/types.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h> #include <unistd.h>
#include <fcntl.h>
/********************************************************************** /**********************************************************************
* Global variables * Global variables
@ -29,9 +30,6 @@ static unsigned int test_id;
static FILE *observed_stream_w; static FILE *observed_stream_w;
static FILE *observed_stream_r; static FILE *observed_stream_r;
// Temporary pipe for observed data
static char observed_fifo[NAME_MAX];
// Buffer for expected output // Buffer for expected output
static char expected_output[1024]; static char expected_output[1024];
static size_t expected_len; static size_t expected_len;
@ -170,16 +168,40 @@ static void verify_defaults(void)
TEST_LOG(FATAL, filter, fmt, ##__VA_ARGS__); \ TEST_LOG(FATAL, filter, fmt, ##__VA_ARGS__); \
} while (0) } while (0)
static void tap_bailout(const char *msg)
{
printf("Bail out! Error %d %s:%s\n", errno, msg, strerror(errno));
exit(1);
}
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
int fifo_fd_r, fifo_fd_w; int fifo_fd[2];
snprintf(observed_fifo, sizeof(observed_fifo), "%s.fifo", argv[0]); int flags;
mkfifo(observed_fifo, 0777);
fifo_fd_r = open(observed_fifo, O_RDONLY | O_NONBLOCK); if (pipe(fifo_fd) != 0) {
fifo_fd_w = open(observed_fifo, O_WRONLY | O_NONBLOCK); tap_bailout("creating pipe");
observed_stream_r = fdopen(fifo_fd_r, "r"); }
observed_stream_w = fdopen(fifo_fd_w, "w");
/* Set the pipe to be non-blocking */
flags = fcntl(fifo_fd[0], F_GETFL);
if (flags < 0) {
tap_bailout("fetching read pipe flags");
}
if (fcntl(fifo_fd[0], F_SETFL, flags | O_NONBLOCK) < 0) {
tap_bailout("setting read pipe to nonblocking");
}
flags = fcntl(fifo_fd[1], F_GETFL);
if (flags < 0) {
tap_bailout("fetching write pipe flags");
}
if (fcntl(fifo_fd[1], F_SETFL, flags | O_NONBLOCK) < 0) {
tap_bailout("setting write pipe to nonblocking");
}
observed_stream_r = fdopen(fifo_fd[0], "r");
observed_stream_w = fdopen(fifo_fd[1], "w");
verify_defaults(); verify_defaults();
@ -196,9 +218,8 @@ int main(int argc, char **argv)
pinelog_close_output_stream(); pinelog_close_output_stream();
fclose(observed_stream_r); fclose(observed_stream_r);
close(fifo_fd_w); close(fifo_fd[0]);
close(fifo_fd_r); close(fifo_fd[1]);
unlink(observed_fifo);
return 0; return 0;
} }