Previous commit used pr_err/pr_debug because it mistakenly assumed that
the device pointer was not available. This ensures that the driver uses
the dev_err and dev_dbg functions wherever it can.
err macro has been removed entirely from the Linux kernel starting from
around v3.5, while the dbg macro has been deprecated. Since the lines
that were using err/dbg did not have access to the device, simply log as
a generic kernel log.
The le32_to_cpu function doesn't quite work for some reason. Manually
writing the 32-bit conversion seems to fix the axes reporting for
ABS_X, ABS_Y and ABS_RZ.
This still could use a bit of investigation to see why
input_set_abs_params called with non-zero values for fuzz and flat
causes axis motion to be ignored, although it may be a driver
subsystem issue in Linux.
Due to plans to scrap the kernel module approach and go with a full-fledged
userspace application, this commit renames the driver folder to kernel_module
so the folder contents are clear.
This brings in changes to make the kernel module act like an input
device. However, this version does have one flaw, in that the axes
input for all the centered axes does not work. This is most likely
due to a bug in the invocation of input_set_abs_params. Only the
throttle and slider axes work, as does the hat. The other (minor)
issue is that the hat values show up as -32767 and +32767 instead
of -1 and +1 like the usbhid driver.
Because the joystick type was never set, the input irq handler never
called the x52pro_decode_urb function. This fixes that issue, however,
it still needs verification that the changes work.
This change adds an input device for the Saitek X52 pro flight control
system. However, with this change, there is some bug which causes a
kernel crash. Still debugging, but committing so that I don't lose data.
This adds a list of supported devices with flags for each device.
The flags control whether the MFD and/or LED are supported for
each supported device.
This also changes the deadzone structure to be more compliant with
the fuzz and flat parameters for absolute input.
This change moves the common definitions to their own file so
that we can later rewrite the driver to accept the structure
as input.
A caveat with this approach is that it does prevent shell scripts
from updating the joystick, however, it eases the burden of
verification in the kernel, and it's not too hard to write
wrapper programs to write kernel structures to the files.
Earlier versions of the module could be rmmod'ed while the X52 joystick
was still plugged in and running. Unplugging the joystick after the
module was removed resulted in a kernel crash.
With this change, the X52 USB control API is moved to it's own
file in order to better separate the code and make it cleaner.
This change also renames the kernel module to saitek_x52.
This commit adds sysfs files to enable or disable the LEDs on the
X52 Pro joystick. This also fixes a minor bug with the brightness
API which was always complaining not-supported.
This still has a bug in that the text is not written correctly. It
shows up as garbage. For now, I'm committing it so that I can work
on it later after the brightness configuration is set up.
Also add the commands header file.
This is pretty much bare bones code to get a basic sysfs filesystem
in place. It has only code to create sysfs files for the 3 MFD lines.
Right now, this needs to be enabled by unplugging the joystick,
insmod'ing the x52joy.ko module, rmmod'ing the usbhid module and
replugging the joystick. We don't yet have a /dev/input/ interface
and there's no interrupt message handling yet.
nirenjan
Nirenjan Krishnan